CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Blood draw kit gives error every time I draw toxic acidic blood from acidic zombie #76275

Open CoroNaut opened 1 week ago

CoroNaut commented 1 week ago

Describe the bug

As title, see picture for in-game error and debug.log for trace. It ends up working anyways, and the blood goes into the blood draw kit all the same.

Attach save file

TESTINGTWO-trimmed.tar.gz

Steps to reproduce

  1. Spawn blood draw kit
  2. Spawn acidic zombie
  3. Try to collect toxic acidic blood

Expected behavior

There shouldn't be an error when collecting toxic acidic blood

Screenshots

image

Versions and configuration

Additional context

debug.log

Night-Pryanik commented 1 week ago

I think #67382 is the culprit. Previously drawing blood from acidic zombie generated acidic blood, and then function exited.

This change https://github.com/CleverRaven/Cataclysm-DDA/pull/67382/files#diff-99adfdaa9690fab771878f30cd5fe3b30b0d4e87f994e1d4176cf3331fcd906fL4646 made it so draw kit drew acidic blood and immediately after that it tried to put "default" blood in vacutainer, but can't do this because it can't mix default blood - blood in the error message - and acidic blood.