MoM Blink spell actually generates the random number instead of describing the number as random

dev-dsp commented 2 months ago

Describe the bug

cdda-2024-09-09_03.55.37.webm

Attach save file

Nairn-trimmed.tar.gz

Steps to reproduce

Open spellcasting menu
Scroll to Blink

Expected behavior

Good old static numbers

Screenshots

No response

Versions and configuration

OS: Linux
- OS Version: LSB Version: n/a; Distributor ID: Gentoo; Description: Gentoo Linux; Release: 2.15; Codename: n/a;
Game Version: cdda-experimental-2024-09-08-2121 515ac7b [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Mind Over Matter [mindovermatter], Stats Through Kills [stats_through_kills], SpeedyDex [speedydex] ]

Additional context

No response

Standing-Storm commented 2 months ago

Blink has RANDOM_AOE--that might be the reason for this.

db48x commented 2 months ago

Yes, the problem is that the code that generates the description of the spell actually generates the random number instead of describing the number as random. Currently the menu recreates the description on every frame, which is itself a bug (and one that will be fixed elsewhere), and thus the number changes every time the window is updated.

Since I’m already in the process of fixing the other bug, why don’t you change the title of this bug to something more specific about the spell description. Both bugs need to be fixed, and it would be a shame to forget about it once the menu no longer shows the description changing every frame.

dev-dsp commented 2 months ago

@db48x does this need confirmation label then?

db48x commented 2 months ago

The bug definitely exists, but I can’t edit labels myself or I would already have confirmed it.

CleverRaven / Cataclysm-DDA