CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

The UPS charges devices too fast #76331

Open IdleSol opened 2 months ago

IdleSol commented 2 months ago

Describe the bug

Currently, the charge rate is 1 kJ per second. In my opinion, this is a very high charge rate.

For example, a smartphone with 56 charges will charge from 0% to 100% in 56 seconds.

Attach save file

n/a

Steps to reproduce

  1. Standard world and character
  2. Locate any electronic device (smartphone)
  3. Create a UPS
  4. Turn on the UPS
  5. Observe the change in charge of the electronic device.

Expected behavior

Several alternatives

  1. Expanding the charge_rate parameter beyond “use_action”: {“type”: “link_up” ...}.
  2. Additions of the rule: device charging rate = N x power_draw

Screenshots

No response

Versions and configuration

Additional context

No response

PatrikLundell commented 2 months ago

Isn't this another issue of deficient energy resolution? Charging rate ought to be per second, because that's the rate of the game, but the charging rate ought to be capable of being other than multiples of kJ/s, including, of course, less than 1 kJ/s.

CoroNaut commented 2 months ago

Instead of defining a charge rate per device, perhaps we could get some standard charge rates per light/medium/heavy battery, and have them charge accordingly. There would be less guessing on how fast a specific device charges, less maintenance in code, and it would automatically scale for more electronics in the future.