tried to put an item (water_clean, amount 1) in a container (heattank) that cannot contain it

[dev-dsp]

Describe the bug

Siphoning clean water between heated tanks of my vehicle doesn't work. I've just purified the water in the tank that is beneath a funnel and collects water (32L), now trying to move it to a clean water heated tank (1L), and getting that crash.

Attach save file

Nairn-trimmed.tar.gz

Steps to reproduce

1. e 5 e
2. s
3. choose one of heated tanks
4. choose another heated tank

Expected behavior

Able to move liquids between vehicle tanks

Screenshots

Versions and configuration

• OS: Linux
  • OS Version: LSB Version: n/a; Distributor ID: Gentoo; Description: Gentoo Linux; Release: 2.15; Codename: n/a;
• Game Version: cdda-experimental-2024-09-08-2121 515ac7b [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Mind Over Matter [mindovermatter], Stats Through Kills [stats_through_kills], SpeedyDex [speedydex] ]

Additional context

DEBUG : tried to put an item (water_clean, amount 1) in a container (heattank) that cannot contain it

FUNCTION : int item::fill_with(const item&, int, bool, bool, bool, bool, Character*) FILE : src/item.cpp LINE : 12360 VERSION : cdda-experimental-2024-09-08-2121 515ac7b

[mqrause]

The water of one tank shows as frozen for me:

So it's somehow the revival of #63536?

[dev-dsp]

Hmmmmmmm It was definitely not frozen (as seen on my screenshot) And I've tried to put 32L->1L, so it makes sense that it's not possible to move frozen water out of a tank.. Okay, then it's minor, probably just UI was not updated somehow

[dev-dsp]

If it shows as frozen on save load, then it's probably not that easy to reproduce and can be closed, unless there are any ideas on what could've happened here

[mqrause]

It's still an issue, since as far as I'm aware, you should be able to pour a liquid into a tank with the same liquid but frozen.

[dev-dsp]

Please read my comments again :sweat_smile: I've tried to merge 32L (which turns out to be frozen, just not showing it in UI) to 1L (which is not frozen)

[mqrause]

I meant it shouldn't be closed, because the error message you put in the title doesn't actually come from the UI issue but the fact the liquids can't be combined for some reason.

The UI not displaying the actual state and thus also allowing you to select a frozen liquid for siphoning is a different issue on top of that.