CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Receiving pain while crafting is ignored despite distractions manager having pain disabled #76389

Open CoroNaut opened 1 month ago

CoroNaut commented 1 month ago

Describe the bug

Distractions manager is supposed to suppress messages that require player input. Pain is one of those. However, crafting with conjunctivitis ignores that the pain distraction is disabled and give you a popup anyways.

Attach save file

Grafton-trimmed.tar.gz

Steps to reproduce

  1. Get conjunctivitis or any other effect that cause pain slowly
  2. Go into distractions manager and set pain to disabled
  3. Start a craft
  4. Pain message still pops up while in the middle of crafting

Expected behavior

Pain popup should be suppressed when it is disabled through distractions manager

Screenshots

image image image

Versions and configuration

Additional context

No response

mqrause commented 1 month ago

I'm fairly sure that's not just pain but actual damage.

CoroNaut commented 1 month ago

I saw rare: pain in effects and thought it was only pain, I didn't realize it was damaging as well. However, I don't think I'd classify this distraction as anything other than pain. It isn't really an attack, (unless we consider it attacking yourself) and the rest of the distractions don't fit. So even if it is actual damage, classifying it under pain in this instance might be best.