Segmentation Fault when consuming antiseptic from vehicle tank

[BaumgeistOne]

Describe the bug

Why should antiseptic take up precious cargo space, when it could be stored in a vehicle tank? So I did exactly that. But since it does not show up in the "use meds" action anymore, I tried to siphon it, and when prompted what to do with the liquid, I selected "consume". Which then crashed the game.

Attach save file

The Collector-trimmed.tar.gz

Steps to reproduce

1. Load the save or use own world and fill antiseptic into a vehicle tank.
2. Examine vehicle, siphon antiseptic.
3. Choose "consume".
4. Choose the limb.
5. Enjoy yet another way to trigger a segfault. :)

Expected behavior

"Consuming" the antiseptic after siphoning it should work.

Screenshots

No response

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Tuxedo; Description: TUXEDO OS 3; Release: 22.04; Codename: jammy;
• Game Version: cdda-experimental-2024-09-09-0452 75f6cdeb12 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Bionic Professions [package_bionic_professions], Magiclysm [magiclysm], Mind Over Matter [mindovermatter], Xedra Evolved [xedra_evolved], Bombastic Perks [bombastic_perks], Extra Mutated Scenarios [extra_mut_scens], Mythical Martial Arts [MMA], Bionic Slots [cbm_slots], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], SpeedyDex [speedydex], Stats Through Skills [StatsThroughSkills], DinoMod [DinoMod], Megafauna [megafauna], Disable NPC Needs [no_npc_food] ]

Additional context

CddaCrashDebug.zip

[CoroNaut]

Tested on a more vanilla CDDA, got segfault as well. Placed antiseptic into tank, damaged self, tried to 's'iphon antiseptic, consumed it, segfault. crash.zip TESTINGFIVE-trimmed.tar.gz

• OS: Windows
  • OS Version: 10.0.19045.4651 (22H2)
• Game Version: cdda-experimental-2024-09-12-1206 6341fd2 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

[PatrikLundell]

Failed to repeat from "CoroNaut's save. Instead I get an error report (and no PR is currently marked as linked to this issue): DEBUG : Item location/name to be consumed should not be null.

FUNCTION : finish FILE : C:\Cataclysm-DDA\src\activity_actor.cpp LINE : 3245 VERSION : 0.G-12039-g2473620ec6 and nothing is removed from the tank, nor is the wound I debugged in the PC disinfected.

• OS: Windows
  • OS Version: 10.0.19045.4894 (22H2)
• Game Version: 0.G-12039-g2473620ec6 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

[mqrause]

It's the same commit as in #76425 that's responsible for this (717630e2cfc00dd58d1ef3dd3de40e4f63cf2618). But in this case the actual issue is that vehicle item_locations are only valid for CARGO vehicle parts. Liquid tanks work differently and can't use them.

[mqrause]

So actually the above isn't exactly false, but even without that issue there is a crash, because the first aid activity always assumes the healing item you use is on the character, so it can't handle antiseptic coming from a vehicle tank currently.