CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.29k stars 4.12k forks source link

Enhanced hearing CBM should cancel trait "Poor Hearing" #76612

Open CoroNaut opened 4 hours ago

CoroNaut commented 4 hours ago

Is your feature request related to a problem? Please describe.

Its clear that the enhanced hearing CBM replaces the users middle/inner ear parts. These being ~the main~ a portion of the ear that could contribute to poor hearing. I'm thinking the enhanced hearing CBM replaces those completely, which should probably cancel the poor hearing trait.

Your middle ear consists of your [eardrum tympanic membrane and your ossicles (tiny, sound-conducting bones called the malleus, incus and stapes). Your eardrum sits at the very end of your ear canal. Your ossicles — located on the other side of your eardrum — carry sound vibrations to your inner ear.

Your inner ear contains a spiral-shaped structure called the cochlea (which means snail shell). Tiny hair cells line the inside of your cochlea. When sound vibrations reach these hair cells, they transmit signals to your auditory nerve.

Source: https://my.clevelandclinic.org/health/articles/17054-hearing

Solution you would like.

Installing the enhanced hearing CBM should cancel the poor hearing trait.

Describe alternatives you have considered.

None. I don't think there is any way for a user to have the ability of enhanced hearing and deafness from a cbm while still keeping the parts of the biological ear that caused poor hearing.

Additional context

No response

Zireael07 commented 3 hours ago

As a hearing impaired person, I can tell you it's possible to have impaired hearing/deafness while having working biological ear. (In my case, it's the nerves/brain that do not work properly)

I'm surprised to learn that this is the more common kind of hearing loss: https://www.ncbi.nlm.nih.gov/books/NBK565860/ Wikipedia goes as far as to claim it accounts for 90% of cases, which I really doubt (it gives no source for the claim, and I know LOTS of people with the other, conductive, kind)

In spite of this, for gameplay reasons I'm inclined to have the CBM cancel the Poor Hearing trait. Let's assume it fixes the nerves too, or something

CoroNaut commented 3 hours ago

Very interesting. That gives me the idea of having "poor hearing" as well as "nerve-impaired hearing" as two separate negative traits. The regular poor hearing can be a physical impairment and give a slight (-33%) hearing loss. The nerve-impaired hearing could be majority (-66%) hearing loss, and be unable to be fixed with enhanced hearing cbm, only partially negated. Those percent values being an example.

Currently poor hearing is -50%. https://github.com/CleverRaven/Cataclysm-DDA/blob/03763473c2ae6d4e559306c74099890d306a8211/data/json/mutations/mutations.json#L1684

Zireael07 commented 1 hour ago

Tbh I wouldn't go as far as to split the two (btw either type can be light or severe, it varies from person to person)

When it comes to gameplay, the two are in practice the same.