search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

zapped. Change the maximum duration of the effect #76837

Open IdleSol opened 1 month ago

IdleSol commented 1 month ago

Describe the bug

https://github.com/CleverRaven/Cataclysm-DDA/blob/65aca7f154933aa62002d95d3e178a0fe8619452/data/json/effects.json#L3995

    "max_duration": "2 s",
    "dur_add_perc": 20,

A search on this effect tells me that there are monsters that should impose it on a random number between 2 and 10 seconds. For example: zapping zombfrog https://github.com/CleverRaven/Cataclysm-DDA/blob/65aca7f154933aa62002d95d3e178a0fe8619452/data/json/monsters/zed_amphibian.json#L260

Currently, regardless of the result of the cubes, the duration of the effect does not exceed 2 seconds.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

  1. I suggest increasing the max_duration parameter to 10 seconds.
  2. (Optional) Decrease the dur_add_perc parameter to 0.

In the first case, this will give an accumulative effect for the duration value. Which will add dur_add_perc x duration until it reaches the maximum value. Right now dur_add_perc is equal to 20 percent. You could potentially keep a character under this effect indefinitely.

In the second case, we remove the ability to accumulate the effect. Presumably making it immune to reapplying the effect until it is complete

Alternatively, change the monsters and remove the duration value. Less calculation, more performance.

Screenshots

No response

Versions and configuration

master

Additional context

No response

worm-girl commented 1 month ago

As I recall, the effect is supposed to represent momentary numbness/paralysis from a shock and the 2 second cap was intentional. The frog is newer, so I assume it's wrong.