panacea. Change the maximum duration of the effect

[IdleSol]

Describe the bug

https://github.com/CleverRaven/Cataclysm-DDA/blob/65aca7f154933aa62002d95d3e178a0fe8619452/data/json/effects.json#L4419

   "max_duration": "10 s",

The maximum duration is set to 10 sec.

https://github.com/CleverRaven/Cataclysm-DDA/blob/65aca7f154933aa62002d95d3e178a0fe8619452/data/json/items/comestibles/med.json#L2080

And for it to work properly, it has to be at least 1 minute.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

Set the maximum duration parameter to 60 seconds.

Screenshots

No response

Versions and configuration

master

Additional context

No response

[TheMurderUnicorn]

So, I was going to do this because I was looking for easy issues to fix but you've provided basically no explanation or context for why this change should occur. Last I checked Panacea took effect immediately, but the implication here is that it does not work if used for less than a max duration of 60 seconds.

Please provide additional context on why the change is necessary, or how you came upon this issue, or literally anything that might inform someone unfamiliar who wants to help solve your issue. Additionally, this appears to be like a one character PR, and you seem capable of finding things in the code for yourself, and have a github account already set. If you know the issue, have found the issue in the code and identified where/how to fix it, why not submit this one character change yourself?

[IdleSol]

This topic is a spin-off from drug testing. #76830

I compared the expected duration of the drug and the maximum duration of the effect. If the expected duration was longer than the maximum duration. I created separate topics. Panacea, is one such topic. (There are several others if you're interested)

Additionally, this appears to be like a one character PR, and you seem capable of finding things in the code for yourself, and have a github account already set.

Based on the pill. It's supposed to work for 60 seconds. Based on the effect, 10 seconds. I don't know how long it's supposed to work. I'm not the author and I don't know what he intended.

It could be a mistake. Or maybe since the panacea was added, there have been changes in the mechanics of how the vitamins and effects work. I don't take it upon myself to judge.

P.S. You can assume that I'm just lazy.

[TheMurderUnicorn]

I was looking at the other issues, which do have merit. IE: If painkiller pill is supposed to last 3 hours but max effect is less than that, painkiller pill won't work past the effects max duration. I meant for panacea specifically, I'm reasonably sure it works instantly and has no ongoing effects, so being capped lower is not a major issue. But that also means that it doesn't hurt to match the durations. I was just curious if there was some glaring issue I was missing that brought this up, before I realized there were several issues about several inconsistencies with medications.

That said, related to the other PRs, I have not looked at everything in detail so no promises that I will actually do anything.

And I would push back on "you're just lazy" because you went through the trouble of looking up the disparities and that is most likely more work than making the change but alright.

[IdleSol]

I'm reasonably sure it works instantly and has no ongoing effects

Panacea increases parameters.

    "id": "panacea",
    "max_duration": "10 s",
    "base_mods": { "speed_mod": [ 20 ], "str_mod": [ 2 ], "dex_mod": [ 2 ], "int_mod": [ 2 ], "per_mod": [ 2 ] }

[TheMurderUnicorn]

You know what? x_x That was right on my screen and I completely ignored it focusing on the cureall effect. My mistake.