search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.67k stars 4.18k forks source link

Evolution should default to 1 #77157

Open Procyonae opened 1 month ago

Procyonae commented 1 month ago

Describe the bug

Evolution scaling defaults to 4 and is used in 3 places currently: Regular evolution which is annoying but ok as it's obvious that's going to be affected so you can expect peeps to /4 the base half life Starts/ends for monster groups which while it makes sense to be affected isn't at all intuitive that you should be /4 the days meaning the majority if not all usages are probably 4* larger than intended This alternate method of changing monster group spawns over time that is completely unused in repo as far as I can see and is superceded by starts/ends as far as I can tell https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/JSON_INFO.md?plain=1#L1835-L1837

Attach save file

N/A

Steps to reproduce

N/A

Expected behavior

Change default evolution scaling to 1 with versioned save migration to quarter it on update 4 all current base half lifes unless they seemed like they forgot evolution scaling was defaulted to 4 4 any groups starts/ends that appreciated it was affected by scaling Remove replace_monster_group/new_monster_group_id/replacement_time code

Screenshots

No response

Versions and configuration

N/A

Additional context

If noone has a good reason why evolution scaling should remain defaulted to 4 or why replace_monster_group/new_monster_group_id/replacement_time isn't entirely superceded by starts/ends I'll do this myself soon

PatrikLundell commented 1 month ago

If this is an integer (the reference claims its value is one), it could be that they thought the resolution was too coarse if the unit was 1, and so went with 0.25 as the unit. Just a random guess, with nothing beyond it being an integer to support it.

Procyonae commented 1 month ago

No it's a float, you can change it between 0.01 and 100 currently at world creation, Harakka found that it was changed to 4 in https://github.com/CleverRaven/Cataclysm-DDA/pull/14077 which was just a balance change but by changing the default rather than the half lifes or the calc they made the half life values no longer represent days which is what this would seek to revert to make it less confusing/mistake prone for contributors

RenechCDDA commented 1 month ago

Yes huge agree