CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.7k stars 4.2k forks source link

Repeatable Segfault when trying to Path to landmine 0.H #77246

Open Sirbab opened 1 month ago

Sirbab commented 1 month ago

Describe the bug

When trying to path to the landmine in my save using the (V)iew menu, the game will segfault. I'm not sure exactly why the game does this, but I've attached a crash log. crash.log

Attach save file

Lakesky-trimmed.tar.gz

Steps to reproduce

When loading into the world, press V, then select the land mine, then press T to try to path to it, observe segfault.

Expected behavior

I expect the game not to segfault on 0.H RC

Screenshots

image image

Versions and configuration

Additional context

config.zip I tried to upload a regular compressed zip file of the save too, but it was 38/25 mb. If helpful, i can like double compress it to make it fit.

kevingranade commented 1 week ago

Tracing through the references in the backtrace, it looks like the relative_parts cache is bad, possibly it's just not generated yet and this specific menu operation manages to access it without it being populated first?

kevingranade commented 1 week ago

hrm, loaded your save and pathed to the mine, stopped one tile short, no crash. Checked and vehicle::refresh(), responsible for updating relative_parts, is being called before you have a chance to act, so that's not it.

kevingranade commented 1 week ago

Looks like the same backtrace as #76441 unfortunately they clarified that they can only reproduce the crash on windows so I can't look into it.