CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.67k stars 4.18k forks source link

Error each time killing a zombie child #77393

Open AdamBrezik opened 3 weeks ago

AdamBrezik commented 3 weeks ago

Describe the bug

Each time I kill a zombie child: DEBUG : invalid monster type id "mon_zombie_bio_op"

FUNCTION : const T& generic_factory::obj(const string_id&) const [with T = mtype] FILE : src/generic_factory.h LINE : 482 VERSION : cdda-experimental-2024-10-27-0438 d515611

It goes on for a while now, started happening since an update ~two weeks ago. Only happens on the world from previous version.

Attach save file

Save.zip

Steps to reproduce

  1. Kill a zombie child.

Expected behavior

No remorse, it's already dead. Life's good.

Screenshots

No response

Versions and configuration

OS: Windows 10 Pro 64-bit 22H2 19045.5011 Game Version: d515611 (tiles) Ingame Language: Inglés

Additional context

No response

osuphobia commented 3 weeks ago

Checking kills tab in achievement panel will also cause this error.

AdamBrezik commented 3 weeks ago

I see. I killed one bio operator in the past: "mon_zombie_bio_op": 1 But I can't see it in the kills tab. When I remove this record from the JSON, the error is gone in diary.

Perhaps ID of that monster has changed EDIT: it seems bio operator has been removed from the game completely. But the update didn't take into account the existing record in kills? But I still don't get the relation to zombie child. And the error is still present while killing a zombie child.

osuphobia commented 3 weeks ago

Killing monsters with death_guilt seems to be causing it. And, if you delete all the strings in your save (not only in kill_tracker, but also in character_butchered_corpse, mon_zombie_medical_regenerating, character_ranged_attacks_monster), the error is gone.

AdamBrezik commented 3 weeks ago

I confirm that fixes the issue, however it seems weird to me that this hasn't been removed by the update. Anyway, thanks!

AdamBrezik commented 3 weeks ago

osuphobia found the culprit, workaround was to remove all references of removed object from the save.

harakka commented 3 weeks ago

Reopening, this is a valid bug that we want to track.