CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

Monsters casting a spell will always print a message, even if the message is empty #77436

Open SariusSkelrets opened 3 weeks ago

SariusSkelrets commented 3 weeks ago

Describe the bug

As I was working on the cryptid PR, I noticed that a spell with a blank message would still print a message in the log, which breaks immersion as these spells aren't intended to print messages so they stick out like a sore thumb.

Attach save file

N/A The bug can be replicated without needing precise circumstances.

Steps to reproduce

  1. Load the game with a monster able to cast spells with >message: ""< such as XE's shifter
  2. Spawn said monster
  3. "The shifter casts duplicator shifting at the shifter!" x100

Expected behavior

All spell messages being able to be suppressed, so it preserves the player's immersion without needing stuff such as the shadow's zero-second blind

Screenshots

cast spell 1 cast spell 2

Versions and configuration

Additional context

I'm also including the issue that polymorph will always do a message because both are part of the same issue of spell messages not being possible to hide when spells are casted by monsters.

Standing-Storm commented 2 weeks ago

/confirmed, observed in both of the issues I referenced above.

In addition, sometimes it will even falsely claim that the avatar is the one casting the spell:

Untitled2