Several tools don't show their maximum and available charges

[Night-Pryanik]

Describe the bug

• [ ] flint and steel (2000 charges / 1 charge per use)
• [ ] survival marker (100 charges / 1 charge per use)
• [ ] survival match (1 charge / 1 charge per use)
• [ ] compressed air horn (50 charges / 1 charge per use)
• [ ] portal generator (10 charges / 2 charges per use)
• [ ] teleporter (20 charges / / 1 charge per use)

As such, player can't calculate how much uses tools from the list above have. Player might even think that these items have infinite uses since they are shown as "chargeless" in inventory.

Also there is a

• [ ] Magiclysm's skeleton key of opening (5 charges / 1 charge per use) which has the same problem of not showing its max/available charges, but also it has another bug of having infinite actual uses.

Attach save file

N/A

Steps to reproduce

• Check json definitions for tools listed above. Get these tools ingame and check that they are shown as "chargeless".
• Get Magiclysm's skeleton key of opening, check that it's shown as "chargeless" in inventory. Activate it to open locked doors, check that it has infinite uses instead of intended 5 uses.

Expected behavior

• Tools from the list above should show their maximum and available charges in inventory and while activating.
• Skeleton key of opening should have 5 actual uses.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0.19045.5011 (22H2)
• Game Version: 0.G-13309-g55335a2efb-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth], Magiclysm [magiclysm] ]

Additional context

None.

[Karol1223]

survival match (1 charge / 1 charge per use)

That can probably be done by removing charges from it altogether and making it SINGLE_USE, no? The description already kinda implies that.

[Night-Pryanik]

Yes, I guess this will work.

[ampersand55]

As everything else with charges use a pocket with a magazine consuming ammo, why not represent these using the same system? That way there's no need to keep track of the json fields "initial_charges": 50, and "max_charges": 50,. They can be replaced with the one-liner:

"pocket_data": [ { "pocket_type": "MAGAZINE", "rigid": true, "ammo_restriction": { "generic_charge": 50 } } ],

Generic ammo:

  {
    "type": "AMMO",
    "id": "generic_charge",
    "name": { "str": "use" },
    "symbol": "=",
    "color": "white",
    "description": "A unit representing one use if the item.",
    "flags": [ "TRADER_AVOID", "ZERO_WEIGHT", "NO_DROP" ],
    "volume": "0 ml",
    "ammo_type": "components"
  },

Downsides:

A bit hackey.

There would be a slightly awkward phrasing when examining the item Maximum 50 charges of use.

No support for rand_charges, but that isn't used anywhere what I can see. Random charges have to be defined in the spawn group.

[Night-Pryanik]

We might add a more plausible compressed air type of ammo for air horn.

I definitely remember most of this stuff has names like compressed air horn (20/20), though I don't know when and why it was removed. This is only a display issue, since these tools do check for available charges before use, i.e. even if inventory doesn't show charges, they are correctly consumed by using.