CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

Unvisited relative/proportional members and contained unvisited members aren't being flagged #78044

Open Procyonae opened 5 days ago

Procyonae commented 5 days ago

Describe the bug

Fields that aren't used other than those prefixed with // such as "//3" are meant to error if they're not used so contributors can't accidently misuse fields in the wrong places or typo them etc

Attach save file

N/A

Steps to reproduce

  1. Add something like "relative": { "field_that_doesn't_work_with_relative": "it's_not_like_you'd_silently_fail_right?" } to an item
  2. Load in without errors
  3. Go on with life assuming your field does something

Expected behavior

A skipped member error like image

Screenshots

No response

Versions and configuration

Additional context

No response

ehughsbaird commented 5 days ago

Can confirm: https://github.com/CleverRaven/Cataclysm-DDA/pull/71197

Procyonae commented 5 days ago

Ah yeh, I knew I'd seen something on here about this before I only searched issues though