CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.66k stars 4.18k forks source link

add spicebush and chokeberries #78066

Open NetSysFire opened 18 hours ago

NetSysFire commented 18 hours ago

Summary

Content "Added chokeberries and spicebush"

Purpose of change

More native flora! This is one small step towards making the forest into a forest as it is currently closer to an orchard.

Chokeberry is an incredibly tempting looking berry but is apparently very, very bitter. Which is why it got that name. Apparently birds and wildlife snack on it without issues, we do have such mutation trees but eliminating morale penalties for such foods is not possible yet as far as I know.

Spicebush is a bush with berries that can be used as spice. Apparently you can also brew tea with the leaves, but this I did not implement as we already have enough sources of tea.

Describe the solution

  1. Add chokeberry shrub, item, and smoking result.
    • It is very bitter but it can be smoked. Native americans have used it in pemmican, supporting the statement that it is better smoked. [1] This also mentions its use as dye, so I added this there, too.
    • As you can see above, there are other ways of preparing chokeberry, too but I intentionally skipped those as its just fruit juice with more effort and sieving.
    • Nutrition info and the general web results suggest that chokeberries indeed have around 50 calories per 100g. [2].
  2. Add spicebush shrub, item and smoking result.
    • This can partially replace black pepper and is ideally smoked to preserve it. [3].
    • Spicebush would also grow along rivers, but I am not going to blindly edit the hardcoded C++ river flora again. Not pushing my luck.
    • Yes, it should probably be powdered/crushed but I am skipping this step as it would pretty much only be tedium.
  3. When working on chokeberries, I noticed cranberries were described as sour. They are most definitely not sour. They are bitter as fuck. I know because I was foolish enough to try a fresh one in real life. This is also why I adjusted the morale penalty. I'd only eat those raw if I was starving and even then I'd still reconsider.
  4. General sources of missing plants: https://www.ecolandscaping.org/06/designing-ecological-landscapes/native-plants/more-edible-and-landscape-worthy-native-plants-of-new-england/ and https://www.ecolandscaping.org/09/developing-healthy-landscapes/ecological-landscaping-101/edible-and-landscape-worthy-native-plants-of-new-england/

Describe alternatives you've considered

Testing

Additional context

Two done. Dozens to go. Includes but is unfortunately (due to work needed) not limited to: at least three more fruit bearing trees: the nannyberry, the tupelo/black gum and black cherry (Prunus serotina). Maybe also chokecherry (not to be confused with chokeberries). And some more bushes: foxgrape, add groundnut beans (addition to the existing plant), indian cucumber probably, maaaybe staghorn sumac and wild raisin/witherod and hobblebush plus wild strawberry. New England has a lot of virburnum/grape stuff. That and some attention to edible flowers (mostly results in more plant stalks I guess).

github-actions[bot] commented 18 hours ago

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand * %s, **chokeberries** * A handful of black **chokeberries**. They look similar to blackcurrant. Big and juicy but actually exceedingly bitter. * handful of **chokeberries** * handfuls of **chokeberries**

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary * If the word is normally in all lowercase, such as the noun `word` or the verb `does`, add it in its lower-case form; if the word is a proper noun, such as the surname `George`, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym `CDDA` or the unit `mW`, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence. * For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.
TheShadowFerret commented 17 hours ago

Apparently you can also brew tea with the leaves, but this I did not implement as we already have enough sources of tea.

This objection doesn't make sense, if it conforms to reality then it should exist 🤔

Grouping up various leaves into a few teas so we don't have a billion does make sense though.

NetSysFire commented 7 hours ago

There are so many plants that have leaves or twigs or stalks that are suitable for tea, sometimes with questionable medical effects, too. We already have a lot of tea and making yet another tea item feels like a waste of time. This needs a clean up PR so these all can be merged into a single herbal tea with no medical effects imo. I am busy travelling the next 4 days however and I consider it out of scope anyways.

Night-Pryanik commented 6 hours ago

It is very bitter

I haven't tasted it myself, but sources I read says it has sweet and sour taste, not bitter one.

NetSysFire commented 6 hours ago

"Astringent" may mean bitter, sometimes sour. The very reason chokeberry is named chokeberry is because it is mouth puckering in some way. Do note that some sources confuse other aronia species with black, wild chokeberry (Aronia melanocarpa) and any juice you find is probably sweetened to make it bearable. Plus also confusion of chokeberry vs chokecherry. I have not tasted it myself as I live in Europe, not the US, and have no access to those berries.

In the end this may just be a simple change in wording. But the cranberry, which is also described as astringent, is most definitely very bitter.

logros13 commented 4 hours ago

"eliminating morale penalties for such foods is not possible yet as far as I know."

the taste modifier cbm? (might have gotten the name wrong quoting from memory)