CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

Add test to validate most recent stable save migration. #78070

Open kevingranade opened 4 days ago

kevingranade commented 4 days ago

Is your feature request related to a problem? Please describe.

We have failed to keep up with save migration issues in the 0.G to 0.H development process that there are essentially too many issues to deal with before releasing, putting all of the existing save migration issues would most likely delay the release a further month or more. These wouldn't be so bad if addressed as they occur, but they have languished until the release process is started.

Solution you would like.

Add a test workflow that loads a canonical 0.H save that is loaded with game entities and asserts that it loads without errors. This would allow migration faults to be surfaced in the PR that adds them instead of during some manual check.

Describe alternatives you have considered.

Abandoning save migration is tempting... "just try harder" lol.

Additional context

No response