CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.73k stars 4.21k forks source link

[MoM + No Hope] No Hope prevents MoM map extras from spawning properly #78338

Open Terrorforge opened 22 hours ago

Terrorforge commented 22 hours ago

Describe the bug

Running MoM and No Hope together prevents the spawning of MoM's overmap extras, most notably the crystal clusters that are the primary source of matrix crystals. Sometimes you get a bit of pseudo-terrain in the shape of what the MoM extras look like, but often it seems to just fail silently.

I've also not been able to find any instances of office_cubical_phavian (tested by searching "office" on the map and looking for buildings with "Origin:'Mind Over Matter'", but I have confirmed the presence of both crystal outcroppings and the MoM version of the research facility.

All the missing things are found in MoM's regional_overlay.json, so presumably there's some issue with that. Debug spawning the extras seems to work just fine.

Attach save file

No Mind_TEST-trimmed.tar.gz

Steps to reproduce

Start a game with MoM and No Hope and try to find any map specials.

Expected behavior

Mods do not interfere with each other spawning map extras unless explicitly intended to.

Screenshots

image Some pseudo-terrain that looks like it was meant to be an MoM map extra.

image The MoM Research Facility as it appears with No Hope active. Note the lack of any weird crystal clusters or alien flora intruding on the building. The whole thing looks like this.

image For comparison, a research facility in a game

Versions and configuration

Additional context

No response

Terrorforge commented 22 hours ago

UPDATE: changing the load order of the mods so the MoM comes after No Hope appears to fix this issue. I'm not sure if it still constitutes a bug or not; this is the first time I've encountered load order issues in CDDA, and it's possible that MoM is now overwriting No Hope content instead.

Procyonae commented 21 hours ago

Related issue #74446 I have a branch open changing No Hope to use a region overlay that should fix all this, I'll try to get it up tomorrow (and plan on making most other mods region overlay where appropriate)