CliMA / AtmosphericProfilesLibrary.jl

A library of atmospheric profiles
Apache License 2.0
2 stars 0 forks source link

Make profiles type stable #39

Closed szy21 closed 3 months ago

szy21 commented 1 year ago

Purpose

To-do

Content


codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8808529) 100.00% compared to head (6a11c42) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 252 252 ========================================= Hits 252 252 ``` | [Files Changed](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA) | Coverage Δ | | |---|---|---| | [src/profiles/ARM\_SGP.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0FSTV9TR1Auamw=) | `100.00% <100.00%> (ø)` | | | [src/profiles/DryBubble.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0RyeUJ1YmJsZS5qbA==) | `100.00% <100.00%> (ø)` | | | [src/profiles/Dycoms\_RF01.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0R5Y29tc19SRjAxLmps) | `100.00% <100.00%> (ø)` | | | [src/profiles/GABLS.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0dBQkxTLmps) | `100.00% <100.00%> (ø)` | | | [src/profiles/GATE\_III.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0dBVEVfSUlJLmps) | `100.00% <100.00%> (ø)` | | | [src/profiles/LifeCycleTan2018.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL0xpZmVDeWNsZVRhbjIwMTguamw=) | `100.00% <100.00%> (ø)` | | | [src/profiles/Nieuwstadt.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL05pZXV3c3RhZHQuamw=) | `100.00% <100.00%> (ø)` | | | [src/profiles/Rico.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL1JpY28uamw=) | `100.00% <100.00%> (ø)` | | | [src/profiles/Soares.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL1NvYXJlcy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/profiles/TRMM\_LBA.jl](https://app.codecov.io/gh/CliMA/AtmosphericProfilesLibrary.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL3Byb2ZpbGVzL1RSTU1fTEJBLmps) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charleskawczynski commented 1 year ago

I think the upstream issue is maybe https://github.com/kbarbary/Dierckx.jl/issues/48?

we could alternatively try to fix it there

szy21 commented 1 year ago

I think the upstream issue is maybe kbarbary/Dierckx.jl#48?

we could alternatively try to fix it there

Does it seem like something we can fix easily? cc @simonbyrne This is what I mentioned briefly this morning.

charleskawczynski commented 3 months ago

Superseded by #45.