JOSS review: sinusoid examples and plots in paper

[lm2612]

Purpose

Addresses some remaining points from JOSS review issues #294 and #293

To-do

Edits to example pages (#294)

• [x] For comparison it would be better if the color scale would cover the same range from figure to figure, especially when plotting the errors.
• [x] Maybe add a table with the numeric results, like in the Gaussian process section. This would help to compare the results from Gaussian process and random features.

Edits to paper (#293)

p. 2 L72 "ABC can be used in more general contexts than CES, but suffers greater approximation error and more stringent assumptions, especially in multi-dimensional problems."

• [x] Can you provide a reference for this statement? Or is this something that is immediately clear to a statistician? Does it not also depend on the chosen emulator in CES?

Figure 1

• [x] Rather a cosmetic problem: the legend says true amplitude = 6.99, but the text in the paper says 7.0 (seems to be an artifact from the signal being made up of finite amount of samples, examples/Sinusoid/sinusoid_setup.jl:61). Ok, the legend is the mean, the text is the vertical shift, so perhaps one could consider it a property of the model (or finite number of "measurements"), but it is a bit confusing.

• [x] I think it would make more sense if the observed range (blue double arrow) would be centered with respect to the observed mean (blue dashed line). But your version can be compared to the true values more easily, so feel free to ignore.

Figure 4, caption: "... trained on the re-used calibration pairs"

• [x] The points (scatter plots) do not seem to be the same as in Figure 3. Should they be the same?

See docs edits here

---

• [ ] I have read and checked the items on the review checklist.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.26%. Comparing base (acf1051) to head (ff7990c). Report is 7 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #298 +/- ## ========================================== + Coverage 88.17% 88.26% +0.08% ========================================== Files 8 8 Lines 1184 1184 ========================================== + Hits 1044 1045 +1 + Misses 140 139 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.