JOSS address editor comments

CliMA / CalibrateEmulateSample.jl

Stochastic Optimization, Learning, Uncertainty and Sampling

https://clima.github.io/CalibrateEmulateSample.jl/dev

Apache License 2.0

81 stars 14 forks source link

JOSS address editor comments #305

Closed odunbar closed 2 months ago

odunbar commented 3 months ago

Purpose

Address Editor comments of https://github.com/openjournals/joss-reviews/issues/6372#issuecomment-2059404938

Content

Updated (all attainable DOIs)
Attach Andre's ORCiD
research list now bulleted
CES pipeline description now an enumerated list
formating of e.g., i.e, for example, ...
Figure text is larger in all sinusoid example figs. (and edited the example scripts that produce them)

Not Addressed

Unattainable DOIs: (1) Random Features (Rahimi and Recht 2007) was published in NIPS and there are not DOIs for these conference papers that I can find. (2) SciKitLearn & (3) No-U-Turn sampler papers are published with JMLR which also does not give DOIs.
Author has requested their name remains N. Efrat-Henrici

[x] I have read and checked the items on the review checklist.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.18%. Comparing base (acf1051) to head (e54c79e). Report is 13 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #305 +/- ## ======================================= Coverage 88.17% 88.18% ======================================= Files 8 8 Lines 1184 1185 +1 ======================================= + Hits 1044 1045 +1 Misses 140 140 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odunbar commented 2 months ago

Merged before PR reviewed - as JOSS editor will review