search

CliMA / ClimaAtmos.jl

ClimaAtmos.jl is a library for building atmospheric circulation models that is designed from the outset to leverage data assimilation and machine learning tools. We welcome contributions!
Apache License 2.0
82 stars 16 forks source link

Undefined variable? #1203

Closed Yujie-W closed 1 year ago

Yujie-W commented 1 year ago

Variable prof_v is not defined in method for GATE_III_* https://github.com/CliMA/ClimaAtmos.jl/blob/d0e85d63b6c5bc768881a6bdb2c194b51fab6c86/tc_driver/Cases.jl#L726

Should it be the following as in some other cases without *_v?

set_z!(prog_gm_uₕ, prof_u, x -> FT(0))
charleskawczynski commented 1 year ago

Yes, it looks like it's zero based on the last working version in TurbulenceConvection.jl, here, the case was commented out in this PR, I probably accidentally added a reference to the undefined prof_v in a refactoring PR, not realizing that this code was not exercised

charleskawczynski commented 1 year ago

This code has been refactored away.