search

CliMA / ClimaAtmos.jl

ClimaAtmos.jl is a library for building atmospheric circulation models that is designed from the outset to leverage data assimilation and machine learning tools. We welcome contributions!
Apache License 2.0
81 stars 15 forks source link

Use maxiter=1 for thermo state #1649

Open szy21 opened 1 year ago

szy21 commented 1 year ago

We should use 1 iteration for the thermodynamic state, and use the temperature at the previous time step as the initial condition for the iterations.

bischtob commented 1 year ago

use Thermodynamics.jl data collection feature.

charleskawczynski commented 1 year ago

See https://github.com/CliMA/Thermodynamics.jl/blob/main/src/DataCollection.jl

szy21 commented 1 year ago

1785 set the iteration to 3 and tolerance to 0.003 without an initial guess. With the previous temperature as an initial guess the simulation breaks, see this build for example. It seems temperature can change by 4K in one timestep, which is not physical. One idea is to check the previous q_tot to see if the change is from precipitation.

sriharshakandala commented 4 months ago

@szy21 : Is this issue still active?

szy21 commented 4 months ago

@szy21 : Is this issue still active?

I’m not working on it, but this issue hasn’t been solved.