CliMA / ClimaAtmos.jl

ClimaAtmos.jl is a library for building atmospheric circulation models that is designed from the outset to leverage data assimilation and machine learning tools. We welcome contributions!
Apache License 2.0
71 stars 13 forks source link

Improve enery, mass, and water conservation checks #2568

Open LenkaNovak opened 5 months ago

LenkaNovak commented 5 months ago

As investigated in #2458, we need a global energy and water for more accurate tracking of conservation (to floating point precision), and for tracking of global energy/water with time (indicates type if instability). We can assume a similar approach to ClimaCoupler.ConservationChecker and produce conservation plots, in addition to the quantitative instantaneous asserts to stay within a sqrt(eps) leakage.

QA:

trontrytel commented 4 months ago

@LenkaNovak - is it ok with you to turn the bullet points here into separate issues? I can put my issue about adding mass water and energy checks for the 1M scheme here also

Though technically this is for 1.5.2.d, so maybe better to not merge them?

LenkaNovak commented 4 months ago

@LenkaNovak - is it ok with you to turn the bullet points here into separate issues? I can put my issue about adding mass water and energy checks for the 1M scheme here also

Though technically this is for 1.5.2.d, so maybe better to not merge them?

Of course. Please feel free to adapt the above. This issue was to keep track of what we need to do for conservation in general, but no-one is currently working on it.