SCM runs with incorrect config file diagnostic

CliMA / ClimaAtmos.jl

ClimaAtmos.jl is a library for building atmospheric circulation models that is designed from the outset to leverage data assimilation and machine learning tools. We welcome contributions!

Apache License 2.0

72 stars 13 forks source link

SCM runs with incorrect config file diagnostic #3077

Open Julians42 opened 1 month ago

Julians42 commented 1 month ago

@akshaysridhar and I noticed that if one (me) incorrectly names the reduction the simulation still runs and doesn't throw an error. E.g. in config yml file this is incorrect (reduction_time should just be reduction) but simulation completes: `diagnostics:

reduction_time: average short_name: [ts, ta, ua, va, wa, hur, hus, cl, clw, entr, detr] period: 10mins`

Misspelling short_name (e.g. short_names) or period (e.g. periods) does throw an error as expected.

akshaysridhar commented 1 month ago

Might be useful to fold this into the broader issue that @Sbozzolo started here.

Sbozzolo commented 1 month ago

Yes, this is a more general problem of the interface. Properly fixing it would require some work.