Replace allocation analysis with Profile.Allocs flame graph

CliMA / ClimaCore.jl

CliMA model dycore

https://clima.github.io/ClimaCore.jl/dev

Apache License 2.0

83 stars 8 forks source link

Replace allocation analysis with Profile.Allocs flame graph #1317

Open charleskawczynski opened 1 year ago

charleskawczynski commented 1 year ago

We should replace the allocations analysis with Profile.Allocs flame graphs because:

using --track-allocations can only be used serially, which is inconvenient
--track-allocations is perhaps getting removed in the near future: https://github.com/JuliaLang/julia/pull/48070 because IIUC, it's not as accurate as Profile.Allocs.

simonbyrne commented 1 year ago

Where is it used? I thought I got rid of it?

charleskawczynski commented 1 year ago

The perf/allocs.jl job

simonbyrne commented 1 year ago

That doesn't use --track-allocations though?

charleskawczynski commented 1 year ago

It does in the script: here

simonbyrne commented 1 year ago

Ah, got it

charleskawczynski commented 1 year ago

I think the right move is to deprecate ReportMetrics.jl. report_invalidations is now in SnoopCompile, and we can probably open a PR to offer to put report_allocs (after stripping out the PrettyTables dep) in julialang's Allocs module after making it use the profiler's output.