Open charleskawczynski opened 1 year ago
Where is it used? I thought I got rid of it?
The perf/allocs.jl
job
That doesn't use --track-allocations
though?
It does in the script: here
Ah, got it
I think the right move is to deprecate ReportMetrics.jl. report_invalidations
is now in SnoopCompile, and we can probably open a PR to offer to put report_allocs
(after stripping out the PrettyTables dep) in julialang's Allocs module after making it use the profiler's output.
We should replace the allocations analysis with Profile.Allocs flame graphs because:
--track-allocations
can only be used serially, which is inconvenient--track-allocations
is perhaps getting removed in the near future: https://github.com/JuliaLang/julia/pull/48070 because IIUC, it's not as accurate as Profile.Allocs.