Calling string(fun) - Githubissues

CliMA / ClimaCoupler.jl

ClimaCoupler: bringing atmosphere, land, and ocean together

Apache License 2.0

21 stars 3 forks source link

Calling string(fun) #833

Open charleskawczynski opened 3 weeks ago

charleskawczynski commented 3 weeks ago

This kind of looks like a bug: datafile_latlon = DIR * "/remapped_" * string(Interfacer.name) * ".nc", since name is just a method, this might as well be: datafile_latlon = DIR * "/remapped_name.nc", unless, for some reason, we overload Base.string(::typeof(::Interfacer.name)), which doesn't seem ideal.

juliasloan25 commented 3 weeks ago

Good catch! This function cgll2latlonz is also only called once in a test, so maybe we can move it to test/ and change this to datafile_latlon = DIR * "/remapped_name.nc"