CliMA / ClimaCoupler.jl

ClimaCoupler: bringing atmosphere, land, and ocean together
Apache License 2.0
21 stars 3 forks source link

update manifests #854

Closed AlexisRenchon closed 1 week ago

AlexisRenchon commented 2 weeks ago

Purpose

Closes #758

Sbozzolo commented 2 weeks ago

So, it looks like you are also updating ClimaComms to 0.6.

I wrote some instructions on how to do that here: https://github.com/CliMA/ClimaComms.jl/wiki/Transition-to-ClimaComms.jl-0.6

AlexisRenchon commented 2 weeks ago

@Sbozzolo @juliasloan25 It is my understanding that ClimaAtmos requires ClimaComms 0.6 now, so we can't have ClimaCoupler with ClimaComms 0.5 deps anymore. Is this correct?

Sbozzolo commented 2 weeks ago

@Sbozzolo @juliasloan25 It is my understanding that ClimaAtmos requires ClimaComms 0.6 now, so we can't have ClimaCoupler with ClimaComms 0.5 deps anymore. Is this correct?

You are right. I forgot we needed to use some functions we defined in ClimaComms. So yes, we have to bump to 0.6

AlexisRenchon commented 2 weeks ago

Should be all set - I might do another release for ClimaLand, ClimaAtmos, and update ClimaCoupler this afternoon too

juliasloan25 commented 2 weeks ago

Should be all set - I might do another release for ClimaLand, ClimaAtmos, and update ClimaCoupler this afternoon too

If the additional releases are just for the new microphysics scheme, you can make a release of ClimaAtmos without making one of ClimaLand (unless there are new features we want from land too). I find it convenient to make releases of both at the same time, but it's not strictly necessary (as long as the compats are still compatible between the two).

AlexisRenchon commented 2 weeks ago

@Sbozzolo I am getting a lot of errors in buildkite now... Should I update the instantiate project to .buildkite, like it has been done in other ClimaComms 0.6 PRs?

Does this, for example, require CUDA? (I thought yes because slurm_ntasks: 2

      - label: "MPI Regridder unit tests"
        key: "regridder_mpi_tests"
        command: "srun julia --color=yes --project=test/ test/mpi_tests/regridder_mpi_tests.jl --config_file $CONFIG_PATH/regridder_mpi.yml"
        timeout_in_minutes: 20
        env:
          CLIMACOMMS_CONTEXT: "MPI"
          CLIMACOMMS_DEVICE: "CUDA"
          NPROCS: 2
        agents:
          slurm_ntasks: 2
          slurm_mem: 16GB
Sbozzolo commented 2 weeks ago

Some jobs are still failing, but it looks like CI was not properly trigged. Can you try again?

akshaysridhar commented 2 weeks ago

https://github.com/CliMA/ClimaCoupler.jl/pull/864 builds on this PR to ensure that the hierarchies cases work with the recent changes to ClimaAtmos. I think we can close this and use #864 following a second review of that PR.

akshaysridhar commented 1 week ago

864 has been merged, so I'm closing this PR.