Misc refactoring - Githubissues

CliMA / ClimaCoupler.jl

ClimaCoupler: bringing atmosphere, land, and ocean together

Apache License 2.0

27 stars 5 forks source link

Closed charleskawczynski closed 1 month ago

charleskawczynski commented 1 month ago

This PR applies some miscellaneous refactoring:

use a concrete eltype in AtmosSim, this should improve inference in places
[FT(0)] -> FT[0] guarantees the vector eltype is of type FT, whereas the former pattern may not.
Call ones / zeros when working on scalar fields.
Add ; to separate positional and keyword arguments

charleskawczynski commented 1 month ago

Thanks for fixing this up, @juliasloan25!