search

CliMA / ClimaDiagnostics.jl

A framework to define and output observables and statistics from CliMA simulations
Apache License 2.0
9 stars 2 forks source link

Change storage dictionaries to vectors #86

Closed charleskawczynski closed 1 month ago

charleskawczynski commented 1 month ago

This PR adds and uses a new function, concrete_dict, in an attempt to improve the type information in the storage, accumulators and counters Dicts.

Closes #85

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.19%. Comparing base (7b08031) to head (2943dd4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ========================================== + Coverage 84.90% 85.19% +0.29% ========================================== Files 13 13 Lines 510 520 +10 ========================================== + Hits 433 443 +10 Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charleskawczynski commented 1 month ago

I think this looks good to me!

Would you like to check that it fixes the issues?

Yeah, I'll rebase https://github.com/CliMA/ClimaAtmos.jl/pull/3290 once https://github.com/CliMA/ClimaAtmos.jl/pull/3344 lands and try out this branch

charleskawczynski commented 1 month ago

It looks like we get a lot fewer issues with this branch, we can now see the total number of failures! 🎉

https://buildkite.com/clima/climaatmos-ci/builds/20884#019243e1-e861-408d-a36b-6d8c01abc126