search

CliMA / ClimaDiagnostics.jl

A framework to define and output observables and statistics from CliMA simulations
Apache License 2.0
9 stars 2 forks source link

Fix de-duplication of ScheduledDiagnostics #93

Closed Sbozzolo closed 3 weeks ago

Sbozzolo commented 3 weeks ago

ScheduledDiagnostics didn't implement ==. As a result, they were considered equal when they were identical (===). This is not the intended behavior because of RefValues, which are effectively pointers. This commit implements == for Schedules and ScheduledDiagnostics by looking at the value of the Ref.

Closes #92

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.60%. Comparing base (7bd541a) to head (aad423e). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== + Coverage 85.19% 85.60% +0.41% ========================================== Files 13 13 Lines 520 535 +15 ========================================== + Hits 443 458 +15 Misses 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.