Misc improvements to plant hydraulics

kmdeck commented 1 year ago

Some misc improvements that didnt go into an already large PR, but which would be good to carry out:

[x] add different vc and p to theta functions
use conductance instead of conductivity (if that is what databases have)
pass layer widths instead of compartment surfaces
root tips as prognostic variables - remove allocation in flux_out_roots function
[x] root_depths is not used in the soil+plant hydraulics version - can we store somewhere else so that we dont need to specify in this case?
[x] LAI=SAI=RAI=0 should give zero root extraction
if there are no stem compartments, we still need to specify stem properties.
rename midpoiints ->centers and surfaces -> faces to be in line with finite difference conventions
create a default parameter set
[x] store canopy transpiration in canopy.transpiration and have that be from the entire canopy, not the transpiration per leaf area. then remove the multiply by LAI inside the RHS, and the divide by LAI in update aux.

kmdeck commented 1 year ago

tagging @gagnelandmanna for visibility, but either one of us can work on these or add to this list

gagnelandmanna commented 1 year ago

hi Katherine ok - depending on how i can juggle advancing the other pr and my other work, I will try to get to this but it may take a little while.

kmdeck commented 1 year ago

oh yeah! not assigning to you, but it's all stuff I'd want your opinion on before implementing.

gagnelandmanna commented 1 year ago

okidoki :) always happy to exchange yes

CliMA / ClimaLand.jl