CliMA / ClimaLand.jl

Clima's Land Model
Apache License 2.0
38 stars 10 forks source link

Canopy Model Tutorial Improvements #255

Closed Espeer5 closed 1 year ago

Espeer5 commented 1 year ago

I've written draft tutorials for using the CanopyModel in both standalone mode and as a part of the SoilPlantHydrologyModel (Related to #240) and would love some feedback on what I can improve in the tutorials, visible on the branch "canopy-tutorials":

In particular:

Thanks!

AlexisRenchon commented 1 year ago

Hey Edward, just FYI, if you create a PR, you will be able to preview your docs. Don't hesitate to open a PR! For example the Farquhar model example you linked is from PR #214.

One thing I plan to do for tutorial & visualization is embed a web app in those docs (similarly to the interactive figure in Farquhar page) where a user can for example change [a parameter value or the domain or timestepper,...] then click on a [run] button and it generates an animation of a time series of various things (e.g., GPP, ET, precip, SWC, etc.), then the user can change things again, reclick on run, etc.

I do this with Makie and JSServe and host the web app on an Amazon Azure Ubuntu server.

If that sounds of interest to you and if Renato is happy with you spending some time on this I can help you with it.

braghiere commented 1 year ago

That looks great, @Espeer5! Thanks!

I think it is a great idea to cite each component of the canopy model along with a link to the dynamic docs. It becomes very clear and well exemplified.

Some other useful plots could be the ones that @kmdeck show here, particularly the ones for soil temperature and soil water content.

I like @AlexisRenchon 's suggestion to create a PR, so we can preview your docs. Also, when we have the two-stream coded up, you can work on a dynamic doc for it using Makie. It is a great new tool that has been broadly used by the community and super helpful to understand what the function is actually doing.

Espeer5 commented 1 year ago

I've opened a PR for these tutorials (see #258), however I cannot yet view a preview of the tutorials yet because of a package issue. The tutorials need to load data from the Ozark experiment, which requires using the package Dierckx, which is properly imported but doesn't seem to be installed in the runtime for building the docs. I'm not sure how to fix this, could anyone help me to resolve this issue? (See the docBuild test failure for PR mentioned above)

kmdeck commented 1 year ago

I've opened a PR for these tutorials (see #258), however I cannot yet view a preview of the tutorials yet because of a package issue. The tutorials need to load data from the Ozark experiment, which requires using the package Dierckx, which is properly imported but doesn't seem to be installed in the runtime for building the docs. I'm not sure how to fix this, could anyone help me to resolve this issue? (See the docBuild test failure for PR mentioned above)

hey! so, you need to update the Project.toml in the docs directory to include Dierckx: https://github.com/CliMA/ClimaLSM.jl/blob/main/docs/Project.toml To do so, go to ClimaLSM.jl/docs julia --project ]add Dierckx

then, leave Julia. when you type "git status" you'll see that both that Project.toml and Manifest.toml in docs/ have changed. you would add them both to the PR & commit/push up, and it should run then.

Espeer5 commented 1 year ago

Canopy Tutorial previews: