search

CliMA / ClimaLand.jl

Clima's Land Model
Apache License 2.0
32 stars 8 forks source link

Performance roadmap #586

Open Sbozzolo opened 2 months ago

Sbozzolo commented 2 months ago 
- [x] `top_center_to_surface` allocates at every step - see https://github.com/CliMA/ClimaLand.jl/issues/615
- [ ] https://github.com/CliMA/ClimaLand.jl/issues/588
- [x] Remove `dss!` if not needed
- [ ] Move to ClimaDiagnositcs to avoid the saving callback
- [ ] Address type instabilties in ClimaUtilities
- [ ] Preallocate space for regridded fields, add `regridded_snapshot!` to ClimaUtilities
- [ ] Check norm2
- [ ] Boundary fluxes
- [ ] update_aux in Biogeochem

Attached is a flamegraph for a GPU run for a bucket with resolution 100. This comes from the run introduced in https://github.com/CliMA/ClimaLand.jl/pull/577/files#diff-c59e565d751c44123440feac3f10d5aaf78e58080716fafa54176cdbe44b50cd, with a simulation length of 1 day. image

juliasloan25 commented 2 months ago

the top_center_to_surface allocations will be reduced in #542 - see changes. I'm happy to move to a separate PR if preferred

Sbozzolo commented 2 months ago

the top_center_to_surface allocations will be reduced in #542 - see changes. I'm happy to move to a separate PR if preferred

Reduced or removed?