remove ArtifactWrappers from docs, test, standalone bucket

kmdeck commented 3 weeks ago

Purpose

Removes artifact wrappers dependence from our docs, test, and src except src/Artifacts.jl

To-do

Future PR (ClimaArtifacts) - add these files to ClimaArtifacts Future PR (ClimaLand) - update the functions in src/Artifacts.jl Review

Content

adds a few new files to srcs/Artifacts.jl removes AW from docs, src/standalone/Bucket In test/ we had "era5_t2m_sp_u10n_static_dataset_path" and "era5_t2m_sp_u10n_dataset_path" artifacts, but these were not being used anywhere, so I removed them. @juliasloan25 can confirm

Review checklist

I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,
appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[X] I have read and checked the items on the review checklist.

juliasloan25 commented 3 weeks ago

Agreed that "era5_t2m_sp_u10n_static_dataset_path" and "era5_t2m_sp_u10n_dataset_path" weren't being used! Thank you Kat :)

juliasloan25 commented 3 weeks ago

Is it correct that this is a step towards https://github.com/CliMA/ClimaLand.jl/issues/580, but doesn't close it because ArtifactWrappers is still being used in src/Artifacts.jl?

Sbozzolo commented 3 weeks ago

Is it correct that this is a step towards #580, but doesn't close it because ArtifactWrappers is still being used in src/Artifacts.jl?

Yes, correct. Now ArtifactsWrapper is more contained

CliMA / ClimaLand.jl