CliMA / ClimaLand.jl

Clima's Land Model
Apache License 2.0
36 stars 9 forks source link

Make soil evaporation scheme modular #755

Open kmdeck opened 3 weeks ago

kmdeck commented 3 weeks ago

We will change our evaporation scheme to that of #732 , but eventually add back in this scheme https://github.com/CliMA/ClimaLand.jl/pull/735.

They seem to perform similarly, but the former is slightly more stable.

Coarse sand evaporation site: New scheme: image Old scheme with beta: image

After 334 days: New scheme: image Old scheme with beta: image

braghiere commented 3 weeks ago

Hi Kat, do you know why (i) the model drop in E happens 3 days before the data and (ii) the minimal E is 0 in the model and 1 in the data? It makes me think that something is wrong either with the model, or with the parameters?

kmdeck commented 3 weeks ago

@braghiere Im not sure, but a couple of general comments:

I 100% agree we should look into this more! And should aim to increase the agreement here. But I hesitate to read to much into this one example at this time given that we dont know the soil parameters exactly.

braghiere commented 3 weeks ago

Thanks! That makes sense. Would it be helpful to find an example of observations in a place we know exactly the soil parameters? Shouldn't be too hard to find?

kmdeck commented 3 weeks ago

this would be very helpful! I think we could also ask Dani for his opinion/help, because this example is in one of his papers.