CliMA / ClimaLand.jl

Clima's Land Model
Apache License 2.0
36 stars 9 forks source link

Implicit solver enhancements #809

Open juliasloan25 opened 21 hours ago

juliasloan25 commented 21 hours ago

Purpose

In milestone O2.3.6, we have implemented implicit solvers for RichardsModel, EnergyHydrologyModel, and SoilCanopyModel. As we developed these, we identified some areas for improvement that we want to address at some point, as well as ideas for improved stability that may or may not be necessary. These are documented here.

Cost/benefits/risks

costs: developer time benefits: increased simulation stability, decreased code duplication, more robust code risks: potential regressions if we alter equations

Producers

@juliasloan25 @kmdeck

Components

Inputs

Implicit solvers introduced in #135

Results and deliverables

Maintain or improve stability of implicitly-stepped experiments

Reviewers

@juliasloan25 @kmdeck @dennisYatunin (PRs) @tapios @cmbengue (SDI review)

Tasks

### general implicit stepping
- [ ] #659
- [ ] #661
### SoilCanopyModel
- [ ] #782
### EnergyHydrologyModel
- [ ] #662
- [ ] include boundary condition contributions (if needed)
- [ ] include contribution from drhoe_int / dtheta_l (if needed)
- [ ] understand how to treat soil phase change implicitly
### RichardsModel
- [ ] smooth derivative dPsi/dtheta at theta = \nu (if needed)
tapios commented 18 hours ago

This looks good and thorough to me (though I say that without being familiar with all items here).