search

CliMA / ClimaOcean.jl

🌎 Tools for realistic regional-to-global ocean simulations, and coupled ocean + sea-ice simulations based on Oceananigans and ClimaSeaIce. Basis for the ocean and sea-ice component of CliMA's Earth system model.
https://clima.github.io/ClimaOceanDocumentation/dev/
MIT License
26 stars 7 forks source link

`Similarity_theory = coupled_model.fluxes.turbulent`? #149

Open simone-silvestri opened 3 weeks ago

simone-silvestri commented 3 weeks ago

I am a bit puzzled by having 

similarity_theory = coupled_model.fluxes.turbulent

in this line https://github.com/CliMA/ClimaOcean.jl/blob/0cbb8a57838fbf2a11ed9991a1da2c21e487e131/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl#L32

For me is a bit counterintuitive because turbulent can be a lot of things (for example turbulent fluxes), but similarity theory contains all the specific details to calculate the turbulent fluxes.

The question is, should we change this name to be similarity_theory also in coupled_model.fluxes? In that way, we would be a bit more straightforward.

glwagner commented 3 weeks ago

The question is, should we change this name to be similarity_theory also in coupled_model.fluxes? In that way, we would be a bit more straightforward.

The word turbulent is used as a generalization of similarity_theory --- for example if we wanted to compute turbulent fluxes with an alternative theory (not similarity theory --- for example constant drag coefficient / transfer coefficients).

That said I think we can 1) come up with a better name for the property or 2) forget about supporting constant transfer coefficients.