`set!` for `ECCOMetadata` will inpaint the whole ocean even for a single column grid

CliMA / ClimaOcean.jl

🌎 Tools for realistic regional-to-global ocean simulations, and coupled ocean + sea-ice simulations based on Oceananigans and ClimaSeaIce. Basis for the ocean and sea-ice component of CliMA's Earth system model.

https://clima.github.io/ClimaOceanDocumentation/dev/

MIT License

26 stars 7 forks source link

`set!` for `ECCOMetadata` will inpaint the whole ocean even for a single column grid #174

Open glwagner opened 1 week ago

glwagner commented 1 week ago

It would make sense to restrict the size of the field to fit to the grid in question I think. Here's the code:

https://github.com/CliMA/ClimaOcean.jl/blob/b3b44b709c70b296adb63cf7b2f4552334dcfd1b/src/DataWrangling/ECCO.jl#L295-L303

cc @simone-silvestri

simone-silvestri commented 1 day ago

Yep, it does at the moment. We can optimize this step for single columns if we know the column is in a valid location.

glwagner commented 22 hours ago

Can't we optimize for any regional model? Just cut out the unneeded areas before inpainting.