Closed trontrytel closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
18ffafb
) 98.50% compared to head (f36ec15
) 98.50%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks good. Do you think that the Chen2022_table_B3
set of parameters should be a couple of array parameters instead of separate single values? We could get that change in before the minor release as well.
This looks good. Do you think that the
Chen2022_table_B3
set of parameters should be a couple of array parameters instead of separate single values? We could get that change in before the minor release as well.
Yes, that would be nicer. So we should replace for example this:
[Chen2022_table_B3_As_coeff_1]
value = 0.00174079
type = "float"
description = "part of AS coefficient for ice terminal velocity parameterization - See Table B3 in Chen et al 2022 DOI: 10.1016/j.atmosres.2022.106171"
[Chen2022_table_B3_As_coeff_2]
value = 0.0378769
type = "float"
description = "part of As coefficient for ice terminal velocity parameterization - See Table B3 in Chen et al 2022 DOI: 10.1016/j.atmosres.2022.106171"
[Chen2022_table_B3_As_coeff_3]
value = 0.263503
type = "float"
description = "part of As coefficient for ice terminal velocity parameterization - See Table B3 in Chen et al 2022 DOI: 10.1016/j.atmosres.2022.106171"
with this:
[Chen2022_table_B3_As]
value = [0.00174079, 0.0378769, 0.263503]
type = "float"
description = "part of AS coefficient for ice terminal velocity parameterization - See Table B3 in Chen et al 2022 DOI: 10.1016/j.atmosres.2022.106171"
?
@trontrytel Yes, that looks perfect!
ok - I'll change it and test if I can use the elegant way in CloudMicrophysics. When do you want to do the release @nefrathenrici ?
We can do another release whenever is convenient. I think these changes can all be in one PR.
I have also found another typo: rain_cross_section_size_relation_coefficient_dela
This is a breaking change so we should bump the version. I can update the CloudMicrophysics and Kinematic1D models when it happens. I think they should be the only ones affected