CliMA / ClimaParams.jl

Contains all universal constant and physical parameters in CLIMA
Apache License 2.0
36 stars 6 forks source link

Add bucket model parameters #183

Closed nefrathenrici closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.50%. Comparing base (a782e37) to head (a748020). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ======================================= Coverage 98.50% 98.50% ======================================= Files 2 2 Lines 134 134 ======================================= Hits 132 132 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kmdeck commented 8 months ago

oh, and, we can cite the SLIM model (Laguë et al 2019) for all values

nefrathenrici commented 8 months ago

I also double checked another model and I think these would be better defaults: bucket capacity = 0.2 (m) critical snow amount = 0.05 (m)

@kmdeck Thank you for the comments! One question, does critical snow amount refer to the parameter critical_snow_water_equivalent or another one?

kmdeck commented 8 months ago

I also double checked another model and I think these would be better defaults: bucket capacity = 0.2 (m) critical snow amount = 0.05 (m)

@kmdeck Thank you for the comments! One question, does critical snow amount refer to the parameter critical_snow_water_equivalent or another one?

critical snow water equivalent, thank you!