CliMA / ClimaSeaIce.jl

🧊 Coupled and stand-alone simulations of sea ice for Earth system modeling
https://clima.github.io/ClimaSeaIceDocumentation/dev/
Apache License 2.0
13 stars 1 forks source link

Single column `SlabSeaIceModel` with flexible air-ice and water-ice boundary conditions #14

Closed glwagner closed 10 months ago

glwagner commented 10 months ago

This PR (will) implement a simple example using a zero heat capacity ice model.

Closes #15

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 5.91% and project coverage change: -40.18% :warning:

Comparison is base (778779b) 66.99% compared to head (680f2cc) 26.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## =========================================== - Coverage 66.99% 26.81% -40.18% =========================================== Files 2 7 +5 Lines 103 261 +158 =========================================== + Hits 69 70 +1 - Misses 34 191 +157 ``` | [Files Changed](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA) | Coverage Δ | | |---|---|---| | [src/ClimaSeaIce.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL0NsaW1hU2VhSWNlLmps) | `6.66% <0.00%> (-93.34%)` | :arrow_down: | | [src/SlabSeaIceModels.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL1NsYWJTZWFJY2VNb2RlbHMuamw=) | `0.00% <0.00%> (ø)` | | | [...ryConditions/bottom\_thermal\_boundary\_conditions.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL1RoZXJtYWxCb3VuZGFyeUNvbmRpdGlvbnMvYm90dG9tX3RoZXJtYWxfYm91bmRhcnlfY29uZGl0aW9ucy5qbA==) | `0.00% <0.00%> (ø)` | | | [src/ThermalBoundaryConditions/boundary\_fluxes.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL1RoZXJtYWxCb3VuZGFyeUNvbmRpdGlvbnMvYm91bmRhcnlfZmx1eGVzLmps) | `0.00% <0.00%> (ø)` | | | [...ndaryConditions/top\_thermal\_boundary\_conditions.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL1RoZXJtYWxCb3VuZGFyeUNvbmRpdGlvbnMvdG9wX3RoZXJtYWxfYm91bmRhcnlfY29uZGl0aW9ucy5qbA==) | `0.00% <0.00%> (ø)` | | | [src/EnthalpyMethodSeaIceModels.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL0VudGhhbHB5TWV0aG9kU2VhSWNlTW9kZWxzLmps) | `66.66% <81.81%> (ø)` | | | [...malBoundaryConditions/ThermalBoundaryConditions.jl](https://app.codecov.io/gh/CliMA/ClimaSeaIce.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CliMA#diff-c3JjL1RoZXJtYWxCb3VuZGFyeUNvbmRpdGlvbnMvVGhlcm1hbEJvdW5kYXJ5Q29uZGl0aW9ucy5qbA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

glwagner commented 10 months ago

@jlk9 @simone-silvestri @navidcy this is ready for review.

I think we should wait on tests because the user API will continue to rapidly evolve.

Ideas for the next few PRs: