search

CliMA / ClimaSeaIce.jl

🧊 Coupled and stand-alone simulations of sea ice for Earth system modeling
https://clima.github.io/ClimaSeaIceDocumentation/dev/
Apache License 2.0
15 stars 1 forks source link

Adding a momentum equation and advection to the SlabSeaIceModel #24

Open simone-silvestri opened 9 months ago

simone-silvestri commented 9 months ago

This PR includes some changes, in particular

Still an ongoing work subjected to change

in collaboration with @jm-c

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 0.76336% with 130 lines in your changes missing coverage. Please review.

Project coverage is 17.79%. Comparing base (5c39b77) to head (2a701dc). Report is 3 commits behind head on main.

:exclamation: Current head 2a701dc differs from pull request most recent head f3d211c

Please upload reports for the commit f3d211c to get more accurate results.

Files Patch % Lines
src/SlabSeaIceModels/slab_time_stepping.jl 0.00% 51 Missing :warning:
...SlabSeaIceModels/slab_tendency_kernel_functions.jl 0.00% 32 Missing :warning:
src/SlabSeaIceModels/slab_sea_ice_model.jl 0.00% 21 Missing :warning:
src/SlabSeaIceModels/thickness_advection.jl 0.00% 14 Missing :warning:
...eaIceModels/SlabSeaIceDynamics/nothing_dynamics.jl 0.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== - Coverage 22.80% 17.79% -5.01% ========================================== Files 11 14 +3 Lines 307 399 +92 ========================================== + Hits 70 71 +1 - Misses 237 328 +91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

glwagner commented 9 months ago

Why so many changes all at once?

simone-silvestri commented 9 months ago

Not so many changes actually, just easy time-stepping improvements with some refactoring and adding tracer advection in a way that allows for a sea-ice momentum equation.