search

CliMA / ClimaSeaIce.jl

🧊 Coupled and stand-alone simulations of sea ice for Earth system modeling
https://clima.github.io/ClimaSeaIceDocumentation/dev/
Apache License 2.0
15 stars 1 forks source link

A momentum equation for `SlabSeaIceModel` with `rheology` #25

Closed simone-silvestri closed 3 months ago

simone-silvestri commented 9 months ago

This PR introduces a leap-frog method to solve for the sea-ice momentum equations and a couple of simple "explicit" sea-ice Rheologies

together with @jm-c

requires #24

codecov[bot] commented 9 months ago

Codecov Report

Attention: 215 lines in your changes are missing coverage. Please review.

Comparison is base (727a7d4) 22.80% compared to head (77cd671) 14.63%.

Files Patch % Lines
src/SlabSeaIceModels/slab_time_stepping.jl 0.00% 53 Missing :warning:
...ls/SlabSeaIceDynamics/momentum_stepping_kernels.jl 0.00% 44 Missing :warning:
...SlabSeaIceModels/slab_tendency_kernel_functions.jl 0.00% 32 Missing :warning:
...els/SlabSeaIceDynamics/cavitating_flow_rheology.jl 0.00% 21 Missing :warning:
src/SlabSeaIceModels/slab_sea_ice_model.jl 0.00% 20 Missing :warning:
...aIceModels/SlabSeaIceDynamics/explicit_dynamics.jl 0.00% 16 Missing :warning:
src/SlabSeaIceModels/thickness_advection.jl 0.00% 14 Missing :warning:
...eaIceModels/SlabSeaIceDynamics/nothing_dynamics.jl 0.00% 12 Missing :warning:
...ceModels/SlabSeaIceDynamics/free_drift_rheology.jl 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================== - Coverage 22.80% 14.63% -8.17% ========================================== Files 11 18 +7 Lines 307 485 +178 ========================================== + Hits 70 71 +1 - Misses 237 414 +177 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

glwagner commented 9 months ago

It's too much. Break it into smaller PRs. We aren't going to work this way.

simone-silvestri commented 9 months ago

more than three quarters of the changes in this PR are already in #24. This PR adds very little code beyond that. I would say, let's keep this waiting until #24 is merged

glwagner commented 8 months ago

Ice-ocean stresses belong in the coupled model, not here in ClimaSeaIce. That will resolve the confusion about the role of the reference ice density and reference ocean density (we have places to specify those in OceanSeaIceModel).

simone-silvestri commented 8 months ago

This probably means that the whole sea-ice momentum calculation might go in the OceanSeaIceModel (I think that the ice-ocean stress needs to be calculated implicitly)

glwagner commented 8 months ago

Can we please start with only one rheology?

simone-silvestri commented 8 months ago

Sure I can remove the CavitatingFlowRheology and we can do that in a different PR

simone-silvestri commented 3 months ago

A new branch with a better structure is incoming when #24 is merged. So this can be closed