search

CliMA / ClimaSeaIce.jl

🧊 Coupled and stand-alone simulations of sea ice for Earth system modeling
https://clima.github.io/ClimaSeaIceDocumentation/dev/
Apache License 2.0
16 stars 2 forks source link

Errors in `cooling_then_warming_ocean.jl` #34

Open francispoulin opened 3 months ago

francispoulin commented 3 months ago

I have found some errors in this script but I don't know the library well enough to proposes fixes.

First, this line can be removed as there is no longer a HeatBoundaryConditions.

https://github.com/CliMA/ClimaSeaIce.jl/blob/2dee0f4389ca49fb9b3f702c37e00163ceb01434/validation/ice_ocean_model/cooling_then_warming_ocean.jl#L8

It sems that RadiativeEmission is already imported by ClimaSeaIce.jl. But I have not found an IceWaterThermalEquilibrium. Maybe the name has changed?

Second, IceWaterThermalEquilbrium is not defined but is called in the line below. Maybe the name has changed?

https://github.com/CliMA/ClimaSeaIce.jl/blob/2dee0f4389ca49fb9b3f702c37e00163ceb01434/validation/ice_ocean_model/cooling_then_warming_ocean.jl#L66

Third, SlabSeaIceModel is not defined but is called in line 97.

https://github.com/CliMA/ClimaSeaIce.jl/blob/2dee0f4389ca49fb9b3f702c37e00163ceb01434/validation/ice_ocean_model/cooling_then_warming_ocean.jl#L97

glwagner commented 3 months ago

@simone-silvestri

simone-silvestri commented 3 months ago

There are some leftovers from the refactor that I have to address. In particular, I have not adapted the validation cases to the new syntax. I will deal with this in a new PR

glwagner commented 3 months ago

I think this is an example, so it may also need to be put into the docs

simone-silvestri commented 3 months ago

I am unsure about using this as an example because it uses a hacky IceOceanModel. I would revamp this by using ClimaOcean and it's own OceanSeaIceModel

glwagner commented 3 months ago

Ah ok, then let's scrap it. I'm not sure we should put ClimaOcean into ClimaSeaIce examples. For example, we don't use ClimaOcean in Oceananigans examples.