Fix rendering of `.mp4` animations in Docs

CliMA / ClimateMachine.jl

Climate Machine: an Earth System Model that automatically learns from data

https://clima.github.io/ClimateMachine.jl/latest/

Other

451 stars 78 forks source link

Fix rendering of `.mp4` animations in Docs #2324

Closed navidcy closed 1 year ago

navidcy commented 1 year ago

Description

This PR fixes the rendering of animations in the Tutorials/Ocean section, e.g., at: https://clima.github.io/ClimateMachine.jl/latest/generated/Ocean/geostrophic_adjustment/#Running-the-simulation-and-animating-the-results

[x] Code follows the style guidelines OR N/A.
[x] Unit tests are included OR N/A.
[x] Code is exercised in an integration test OR N/A.
[x] Documentation has been added/updated OR N/A.

navidcy commented 1 year ago

I don't see any of the tutorials in https://clima.github.io/ClimateMachine.jl/previews/PR2324/ weird..

charleskawczynski commented 1 year ago

I’m not sure why the tutorials aren’t showing up. Maybe we need to bors try? This repo has not really been maintained since we started development on ClimaCore

navidcy commented 1 year ago

I’m not sure why the tutorials aren’t showing up. Maybe we need to bors try? This repo has not really been maintained since we started development on ClimaCore

oh, let me close the PR then... no need to bother if the repo is staled

perhaps add a note on the README about repo status?

charleskawczynski commented 1 year ago

perhaps add a note on the README about repo status?

Yes, that's probably a good idea