search

CliMA / Cloudy.jl

:cloud_with_rain: Multi-moment cloud microphysics toy model
Apache License 2.0
15 stars 3 forks source link

Bugfix: 3+ mode simulations #137

Closed sajjadazimi closed 5 months ago

sajjadazimi commented 5 months ago

Higher thresholds (which we have for more modes) need more bins for numerical integrations. Otherwise at small t, S term is not precise and as a result moments are not precise. Consequently, recovering PSD produces large numbers and make the simulations unstable.

closes #136

codecov[bot] commented 5 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d56d2ae) 98.65% compared to head (2327958) 98.80%. Report is 10 commits behind head on main.

Files Patch % Lines
src/ParticleDistributions/ParticleDistributions.jl 97.93% 3 Missing :warning:
src/Kernels/KernelTensors.jl 97.82% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ========================================== + Coverage 98.65% 98.80% +0.14% ========================================== Files 6 6 Lines 372 417 +45 ========================================== + Hits 367 412 +45 Misses 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.