search

CliMA / Cloudy.jl

:cloud_with_rain: Multi-moment cloud microphysics toy model
Apache License 2.0
15 stars 3 forks source link

Remove NumericalIntegration.jl #151

Closed edejong-caltech closed 2 months ago

edejong-caltech commented 2 months ago

Purpose

Removes dependency on NumericalIntegrations.jl, which has deprecated dependencies. Instead we simply re-implement the necessary functionality for Simpson rule integration.

To-do

Content

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.20%. Comparing base (29b59bb) to head (93f3d54). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ========================================== + Coverage 98.17% 98.20% +0.03% ========================================== Files 8 8 Lines 493 502 +9 ========================================== + Hits 484 493 +9 Misses 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sajjadazimi commented 2 months ago

Thank you for doing this. I'm not sure it is finished yet but it looks already good. There are two minor comments about Julia dependency and the placement of the new function.