Closed sajjadazimi closed 5 months ago
moments
a Tuple of Tuples (as in condensation/sedimentation tendencies) instead of SMatrixM
from the new style of CoalescenceTensor to get the order of the moments neededget_finite_2d_integrals
, consider doing two maps: first, just compute the lower right triangle; second, copy those to the upper right triangleAttention: Patch coverage is 96.49123%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 97.67%. Comparing base (
29b59bb
) to head (2233170
). Report is 12 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let's also check on the 3_modes and 4_modes test cases to make sure they are working as expected
Let's also check on the 3_modes and 4_modes test cases to make sure they are working as expected
There was a minor bug in the constructor of CoalescenceData: it used to normalize kernels twice. Now the results look correct again.
Purpose
Make coalescence computations gpu compatible.
I have:
In the Content, I have included