CliMA / Cloudy.jl

:cloud_with_rain: Multi-moment cloud microphysics toy model
Apache License 2.0
15 stars 3 forks source link

fix coalescence #161

Closed sajjadazimi closed 5 months ago

sajjadazimi commented 5 months ago

Purpose

Make coalescence computations gpu compatible.

I have:

In the Content, I have included

edejong-caltech commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.49123% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.67%. Comparing base (29b59bb) to head (2233170). Report is 12 commits behind head on main.

Files Patch % Lines
src/Sources/Coalescence.jl 97.38% 4 Missing :warning:
src/ParticleDistributions/ParticleDistributions.jl 0.00% 1 Missing :warning:
src/helper_functions.jl 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================== - Coverage 98.17% 97.67% -0.51% ========================================== Files 8 9 +1 Lines 493 473 -20 ========================================== - Hits 484 462 -22 - Misses 9 11 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

edejong-caltech commented 5 months ago

Let's also check on the 3_modes and 4_modes test cases to make sure they are working as expected

sajjadazimi commented 5 months ago

Let's also check on the 3_modes and 4_modes test cases to make sure they are working as expected

There was a minor bug in the constructor of CoalescenceData: it used to normalize kernels twice. Now the results look correct again.