Closed bielim closed 4 years ago
Merging #38 into master will decrease coverage by
33.95%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #38 +/- ##
===========================================
- Coverage 97.1% 63.15% -33.96%
===========================================
Files 5 6 +1
Lines 173 266 +93
===========================================
Hits 168 168
- Misses 5 98 +93
Impacted Files | Coverage Δ | |
---|---|---|
src/PDistributions/PDistributions.jl | 0% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7aff453...7699d6d. Read the comment docs.
Just to note, we could easily keep the name the same, and just create an alias:
using Cloudy
PDistributions = Cloudy.Distributions
using Distributions
# Now we can use both
Could also
using Cloudy
import Distributions
d = Distributions.Normal()
or
using Cloudy
using Distributions: Normal
d = Normal()
After thinking about this for a bit, I think we should go with Charlie's suggestion. @bielim, would that be OK with you?
Hey, @charleskawczynski what are the code cov errors here. Not sure, I get it :).
After thinking about this for a bit, I think we should go with Charlie's suggestion. @bielim, would that be OK with you?
Discussed this with Melanie. She's right that PDistributions might be a good name to have. Also because the PDistributions are not normalized.
Hey, @charleskawczynski what are the code cov errors here. Not sure, I get it :).
It's reporting that none of the newly added code is in the test suite (the tests in this PR need to be include
d in runtests.jl)
Discussed this with Melanie. She's right that PDistributions might be a good name to have. Also because the PDistributions are not normalized.
And PDistributions
over ParticleDistributions
? Either way is fine with me, so long it's clear to users :)
@bielim, can you address this :)?
Will do!
This change will prevent conflicts with Julia's Distributions.jl package